impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sailesh Mukil (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala
Date Tue, 28 Nov 2017 22:02:09 GMT
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8439 )

Change subject: IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8439/1/be/src/rpc/rpc-mgr.h
File be/src/rpc/rpc-mgr.h:

http://gerrit.cloudera.org:8080/#/c/8439/1/be/src/rpc/rpc-mgr.h@183
PS1, Line 183:  /// The following strings preserve the Kudu flags original values to restore
in
             :   /// Shutdown() as they will be modified by us.
             :   string flag_save_ca_certificate_file;
             :   string flag_save_rpc_private_key_file;
             :   string flag_save_rpc_certificate_file;
             :   string flag_save_rpc_private_key_password_cmd;
             :   string flag_save_rpc_tls_ciphers;
             :   string flag_save_rpc_tls_min_protocol;
> I don't see where the validators are run when creating Messenger objects. T
The flag validators created with DEFINE_validators() are run automatically when these flags
are assigned values.
https://github.com/apache/incubator-impala/blob/master/be/src/kudu/rpc/messenger.cc#L123-L201

https://gflags.github.io/gflags/#validate

I should have been more clear, it's not when a Messenger object is created.



-- 
To view, visit http://gerrit.cloudera.org:8080/8439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a14a44fdea9ab668f3714eb69fdb188bce38f5a
Gerrit-Change-Number: 8439
Gerrit-PatchSet: 1
Gerrit-Owner: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Nov 2017 22:02:09 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message