impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-6187: Fix missing conjuncts evaluation with empty projection
Date Tue, 28 Nov 2017 19:52:25 GMT
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8623 )

Change subject: IMPALA-6187: Fix missing conjuncts evaluation with empty projection
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/8623/2/be/src/exec/hdfs-scanner.cc
File be/src/exec/hdfs-scanner.cc:

http://gerrit.cloudera.org:8080/#/c/8623/2/be/src/exec/hdfs-scanner.cc@226
PS2, Line 226:     DCHECK_EQ(scan_node_->tuple_desc()->byte_size(), 0);
This seems to violate the invariant that the scan node only produces non-NULL tuples (the
previous version could too). I'm not sure if the planner can produce plans that have a TupleIsNull()
predicate on a scan producing zero slots, because as far as I understand, TupleIsNull() predicates
are only emitted when a slot from the scan is referenced, but I could be wrong - I feel like
there could be some edge case if you get creative with nested loop joins, etc (which pass
the tuple pointers through unmodified).

I think we should either write a dummy non-NULL pointer or have a comment explaining why that's
not necessary.


http://gerrit.cloudera.org:8080/#/c/8623/2/be/src/runtime/row-batch.cc
File be/src/runtime/row-batch.cc:

http://gerrit.cloudera.org:8080/#/c/8623/2/be/src/runtime/row-batch.cc@60
PS2, Line 60:   tuple_ptrs_ = reinterpret_cast<Tuple**>(calloc(1, tuple_ptrs_size_));
I don't think we should zero-initialise this. We can't depend on the tuple_ptrs_ being zero-initialised
since Reset() doesn't zero-initialise them, so it's just unnecessary overhead.



-- 
To view, visit http://gerrit.cloudera.org:8080/8623
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib530f1fdcd2c6de699977db163b3f6eb38481517
Gerrit-Change-Number: 8623
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Nov 2017 19:52:25 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message