impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Revert "IMPALA-5538: Use explicit catalog versions for deleted objects"
Date Tue, 28 Nov 2017 19:40:28 GMT
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8667 )

Change subject: Revert "IMPALA-5538: Use explicit catalog versions for deleted objects"
......................................................................


Patch Set 1:

> (1 comment)
 > 
 > I don't see the conflict in impala-server.cc. Could you add a quick
 > comment in that file to point it out?

It was because this line was changed in the meantime:

VLOG(3) << (item.deleted ? "Deleted " : "Added ") << "item: " << item.key


-- 
To view, visit http://gerrit.cloudera.org:8080/8667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a2cddee5d565384e9de0e61b3b7d0d9075e0dce
Gerrit-Change-Number: 8667
Gerrit-PatchSet: 1
Gerrit-Owner: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Nov 2017 19:40:28 +0000
Gerrit-HasComments: No

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message