impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-6241: timeout in admission control test under ASAN
Date Tue, 28 Nov 2017 01:20:08 GMT
Tim Armstrong has posted comments on this change. ( )

Change subject: IMPALA-6241: timeout in admission control test under ASAN

Patch Set 1:

Commit Message:
PS1, Line 10: 
            : While testing that fix, I discovered that the ASAN build detection logic
            : was failing silently
> Sorry to hear this wasn't working. Thanks for making an improvement.
It looks like it was my bug that caused it to fail actually :) (it's unfortunate that the
silent nature of the failure caused us to go this long without noticing it though).
File infra/python/deps/requirements.txt:
PS1, Line 45: monkeypatch == 0.1rc3
> I don't think anything else is using this, so it can be removed.
File tests/common/
PS1, Line 198: 
> I guess the bug is that this should have been elif.
Oops, that is my bug then - I didn't see this when looking at the code. It doesn't seem like
the changed approach really directly addresses the bug then.
PS1, Line 19: import pytest
> Unused; remove.
PS1, Line 112: is_dev
> Do you want to add ubsan to this method?
PS1, Line 122: runs_slowly
> Do you want to add ubsan to this method?

To view, visit
To unsubscribe, visit

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4ed949cac99b9925f72e19e4adaa2ead370b536
Gerrit-Change-Number: 8652
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <>
Gerrit-Reviewer: Michael Brown <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-Comment-Date: Tue, 28 Nov 2017 01:20:08 +0000
Gerrit-HasComments: Yes

  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message