impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-6241: timeout in admission control test under ASAN
Date Tue, 28 Nov 2017 01:19:26 GMT
Hello Michael Brown, 

I'd like you to reexamine a change. Please visit

to look at the new patch set (#2).

Change subject: IMPALA-6241: timeout in admission control test under ASAN

IMPALA-6241: timeout in admission control test under ASAN

The fix for IMPALA-6241 is to increase the timeout for all slow builds.

While testing that fix, I discovered that the ASAN build detection logic
was failing silently, resulting in it assuming that it was testing a
DEBUG build. The error was:

  Unexpected DW_AT_name in first CU:
  choosing DEBUG

The fix for that issue is to remove the build type detection heuristic
and instead just write a file with the build type as part of the build process.

Before this change I was able to reproduce locally every 5-10 test
iterations. After this change I haven't seen it reproduce.

Change-Id: Ia4ed949cac99b9925f72e19e4adaa2ead370b536
M .gitignore
M CMakeLists.txt
M bin/
M infra/python/deps/requirements.txt
M tests/common/
M tests/custom_cluster/
6 files changed, 61 insertions(+), 143 deletions(-)

  git pull ssh:// refs/changes/52/8652/2
To view, visit
To unsubscribe, visit

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia4ed949cac99b9925f72e19e4adaa2ead370b536
Gerrit-Change-Number: 8652
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <>
Gerrit-Reviewer: Michael Brown <>

  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message