impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-6187: Fix missing conjuncts evaluation with empty projection
Date Mon, 27 Nov 2017 17:42:35 GMT
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8623 )

Change subject: IMPALA-6187: Fix missing conjuncts evaluation with empty projection
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/8623/1/be/src/exec/hdfs-scanner.h
File be/src/exec/hdfs-scanner.h:

http://gerrit.cloudera.org:8080/#/c/8623/1/be/src/exec/hdfs-scanner.h@333
PS1, Line 333: If template tuple is not NULL
what if the template_tuple_ is null?  Doesn't it effectively set it to that as well? i.e.
this case doesn't seem special from an interface perspective.


http://gerrit.cloudera.org:8080/#/c/8623/1/be/src/exec/hdfs-scanner.h@337
PS1, Line 337: HandleEmptyProjection
this has the same name as the KuduScanner method, but they are a bit different. it'd be nice
to either make them similar in terms of their side effects or give it a different name.  Maybe
WriteEmptyProjection()?


http://gerrit.cloudera.org:8080/#/c/8623/1/be/src/exec/hdfs-scanner.cc
File be/src/exec/hdfs-scanner.cc:

http://gerrit.cloudera.org:8080/#/c/8623/1/be/src/exec/hdfs-scanner.cc@215
PS1, Line 215: should
must, or "which don't reference any slots"



-- 
To view, visit http://gerrit.cloudera.org:8080/8623
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib530f1fdcd2c6de699977db163b3f6eb38481517
Gerrit-Change-Number: 8623
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Nov 2017 17:42:35 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message