impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gabor Kaszab (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-2181: Add query option levels for display
Date Wed, 22 Nov 2017 05:15:45 GMT
Hello Lars Volker, Laszlo Gaal, Zoltan Borok-Nagy, Philip Zeyliger, Attila Jeges, Tim Armstrong,
Csaba Ringhofer, Dan Hecht, 

I'd like you to reexamine a change. Please visit

to look at the new patch set (#17).

Change subject: IMPALA-2181: Add query option levels for display

IMPALA-2181: Add query option levels for display

Four display levels are introduced for each query option: REGULAR, ADVANCED,
DEVELOPMENT and DEPRECATED. When the query options are displayed in Impala
shell using SET then only the REGULAR and ADVANCED options are shown. A new
command called SET ALL shows all the options grouped by their option levels.

When the query options are displayed through HS2 interface then the result set
would contain an extra column indicating the level of each option. Similarly
to Impala shell on this interface the SET command only diplays the REGULAR and
ADVANCED options while SET ALL shows them all.

If the Impala shell connects to an Impala daemon that predates this change
then all the options would be displayed in the REGULAR group.

Change-Id: I75720d0d454527e1a0ed19bb43cf9e4f018ce1d1
M be/src/service/
M be/src/service/
M be/src/service/client-request-state.h
M be/src/service/
M be/src/service/impala-server.h
M be/src/service/
M be/src/service/query-options.h
M common/thrift/Frontend.thrift
M common/thrift/beeswax.thrift
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/
M fe/src/main/java/org/apache/impala/service/
M shell/
M shell/
M testdata/workloads/functional-query/queries/QueryTest/set.test
M tests/custom_cluster/
M tests/hs2/
M tests/shell/
18 files changed, 483 insertions(+), 226 deletions(-)

  git pull ssh:// refs/changes/47/8447/17
To view, visit
To unsubscribe, visit

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I75720d0d454527e1a0ed19bb43cf9e4f018ce1d1
Gerrit-Change-Number: 8447
Gerrit-PatchSet: 17
Gerrit-Owner: Gabor Kaszab <>
Gerrit-Reviewer: Attila Jeges <>
Gerrit-Reviewer: Csaba Ringhofer <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Gabor Kaszab <>
Gerrit-Reviewer: Lars Volker <>
Gerrit-Reviewer: Laszlo Gaal <>
Gerrit-Reviewer: Philip Zeyliger <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-Reviewer: Zoltan Borok-Nagy <>

  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message