impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5362 : Preserve case-sensitivity in field titles
Date Tue, 21 Nov 2017 23:14:00 GMT
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8544 )

Change subject: IMPALA-5362 : Preserve case-sensitivity in field titles
......................................................................


Patch Set 1:

I think this is a pretty dangerous change with the potential to break compatibility in non-trivial
ways. I'd prefer to abandon for now unless there is a strong reason to continue down this
path.

Changing the column labels will affect columns stored in the HMS via CTAS, and it will change
column aliases created for inline views and such. Not sure how preserving the case might break
things, but this change will definitely need paranoid testing. My preference would be to defer
this change.


-- 
To view, visit http://gerrit.cloudera.org:8080/8544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia574f0b7d5bdbebace270ce4079632bf29b3f00e
Gerrit-Change-Number: 8544
Gerrit-PatchSet: 1
Gerrit-Owner: ydjainopensource@gmail.com
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Comment-Date: Tue, 21 Nov 2017 23:14:00 +0000
Gerrit-HasComments: No

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message