impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zoram Thanga (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-6225: Query profile date-time strings should have ns precision.
Date Tue, 21 Nov 2017 20:18:22 GMT
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8611 )

Change subject: IMPALA-6225: Query profile date-time strings should have ns precision.
......................................................................


Patch Set 3:

> > (2 comments)
 > >
 > > > (1 comment)
 > > >
 > > > Please add a test as Phil suggested. If we decide to add 64-bit
 > > > timestamps to the profile, please file a JIRA for it.
 > >
 > > Alas, I haven't yet found a quick way to add the test. How does
 > one
 > > get a query id from a query handle/result (returned by
 > > execute_query_async/execute_query)? If I know the query id, that
 > > can be passed to read_profile_page from where we can extract the
 > > fields of interest.
 > 
 > ./experiments/test_process_failures.py and ./webserver/test_web_pages.py
 > looks like they have examples for beeswax and operation_id_to_query_id()
 > looks like for HS2.

Thanks Dan! Have added a new test case that checks nanosecond-precision start and end date-time
stamps.


-- 
To view, visit http://gerrit.cloudera.org:8080/8611
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e124b9c7e0717b8dc2cdab46aea41d74c5f2fd0
Gerrit-Change-Number: 8611
Gerrit-PatchSet: 3
Gerrit-Owner: Zoram Thanga <zoram@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <philip@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zoram@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Nov 2017 20:18:22 +0000
Gerrit-HasComments: No

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message