impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharath Vissapragada (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-6092: avoid drop/create function interactions in e2e tests
Date Mon, 20 Nov 2017 19:40:14 GMT
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/8593
)

Change subject: IMPALA-6092: avoid drop/create function interactions in e2e tests
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/8593/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/8593/1//COMMIT_MSG@10
PS1, Line 10: IMPALA-6215 explains a race between the lib_cache
> The test that's changed was testing for an invalid symbol that was causing 
Fair point, I agree that we caught the bug by fluke when the test case was doing something
totally irrelevant. Like we discussed, I'm ok as long as we fix the test coverage with proper
tests that rely on a single source jar and multiple DDLs (either in this change or with IMPALA-6215)


http://gerrit.cloudera.org:8080/#/c/8593/1//COMMIT_MSG@13
PS1, Line 13: test_udf_invalid_symbol drops a function from that jar, which causes the use
nit: line overflow in multiple places.


http://gerrit.cloudera.org:8080/#/c/8593/1/tests/query_test/test_udfs.py
File tests/query_test/test_udfs.py:

http://gerrit.cloudera.org:8080/#/c/8593/1/tests/query_test/test_udfs.py@422
PS1, Line 422:     check_call(["hadoop", "fs", "-put", "-f", src_udf_path, tgt_udf_path])
Just to be sure, this works ok on local fs right? Basically we "put" from local fs to local
fs.



-- 
To view, visit http://gerrit.cloudera.org:8080/8593
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica3538788b1d2ab5e361261e2ade62780b838e65
Gerrit-Change-Number: 8593
Gerrit-PatchSet: 1
Gerrit-Owner: Vuk Ercegovac <vercegovac@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <vercegovac@cloudera.com>
Gerrit-Comment-Date: Mon, 20 Nov 2017 19:40:14 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message