impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <>
Subject [Impala-ASF-CR] Pin gen build version's git handling to typical git dir.
Date Sat, 18 Nov 2017 01:21:00 GMT
Impala Public Jenkins has submitted this change and it was merged. (

Change subject: Pin gen_build_version's git handling to typical git dir.

Pin gen_build_version's git handling to typical git dir. now specifies --git-dir explicitly, to avoid
fetching the revision of a containing git directory that's not an Impala

This came up when building Impala without a git directory, but within a
build system that happens to have a git directory higher up in the
directory tree.

I tested this by running the script manually and observing
it works identically in the normal case.

Change-Id: I98870a1cb2073ddcf9ba1620e3801e1964930edd
Reviewed-by: Joe McDonnell <>
Tested-by: Impala Public Jenkins
M bin/
1 file changed, 5 insertions(+), 6 deletions(-)

  Joe McDonnell: Looks good to me, approved
  Impala Public Jenkins: Verified

To view, visit
To unsubscribe, visit

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I98870a1cb2073ddcf9ba1620e3801e1964930edd
Gerrit-Change-Number: 8500
Gerrit-PatchSet: 4
Gerrit-Owner: Philip Zeyliger <>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <>
Gerrit-Reviewer: Joe McDonnell <>
Gerrit-Reviewer: Michael Brown <>
Gerrit-Reviewer: Philip Zeyliger <>
Gerrit-Reviewer: Sailesh Mukil <>
Gerrit-Reviewer: Zach Amsden <>

  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message