impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zach Amsden (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-6206: Fix data load failure with -notests
Date Fri, 17 Nov 2017 23:08:43 GMT
Hello Michael Brown, Philip Zeyliger, David Knupp, Tim Armstrong, Joe McDonnell, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/8580

to look at the new patch set (#3).

Change subject: IMPALA-6206: Fix data load failure with -notests
......................................................................

IMPALA-6206: Fix data load failure with -notests

When tests are not built, specifically with -notests, instead of
just -skiptests, the be-test target is omitted by cmake, and since
nothing in impalad depends on uda/udf samples, they are not built.
This causes data load to fail on a clean build.

Just build them anyway under the target ImpalaUdf since they
build in a few seconds.

This shaves a few minutes off data load testing by avoiding
the time spent linking tests.  Note: only emperically, not
scientifically measured.

Testing: Run a clean build
  find . -name 'libud[af]sample.so'
  ./be/build/debug/udf_samples/libudasample.so
  ./be/build/debug/udf_samples/libudfsample.so

Change-Id: Idaa193989d77d56b72db05ad54e1fb0a345938fb
---
M bin/make_impala.sh
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/8580/3
-- 
To view, visit http://gerrit.cloudera.org:8080/8580
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idaa193989d77d56b72db05ad54e1fb0a345938fb
Gerrit-Change-Number: 8580
Gerrit-PatchSet: 3
Gerrit-Owner: Zach Amsden <zamsden@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <philip@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Zach Amsden <zamsden@cloudera.com>

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message