impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-4835 (prep only): create io subfolder and namespace
Date Fri, 17 Nov 2017 17:44:27 GMT
Hello Joe McDonnell, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

to look at the new patch set (#9).

Change subject: IMPALA-4835 (prep only): create io subfolder and namespace

IMPALA-4835 (prep only): create io subfolder and namespace

Instead of using the DiskIoMgr class as a namespace, which prevents
forward-declaration of inner classes, create an impala::io namespace
and unnested the inner class.

This is done in anticipation of DiskIoMgr depending on BufferPool. This
helps avoid a circular dependency between DiskIoMgr, TmpFileMgr and
BufferPool headers that could not be broken with forward declarations.

Ran core tests.

Change-Id: If807f93a47d8027a43e56dd80b1b535d0bb74e1b
M be/CMakeLists.txt
M be/src/exec/
M be/src/exec/
M be/src/exec/hdfs-parquet-scanner.h
M be/src/exec/
M be/src/exec/hdfs-scan-node-base.h
M be/src/exec/hdfs-scan-node-mt.h
M be/src/exec/
M be/src/exec/hdfs-scan-node.h
M be/src/exec/
M be/src/exec/
M be/src/exec/
M be/src/exec/scanner-context.h
M be/src/runtime/CMakeLists.txt
D be/src/runtime/disk-io-mgr.h
M be/src/runtime/
M be/src/runtime/exec-env.h
A be/src/runtime/io/CMakeLists.txt
R be/src/runtime/io/disk-io-mgr-internal.h
R be/src/runtime/io/
R be/src/runtime/io/
R be/src/runtime/io/disk-io-mgr-stress.h
R be/src/runtime/io/
R be/src/runtime/io/
A be/src/runtime/io/disk-io-mgr.h
R be/src/runtime/io/handle-cache.h
R be/src/runtime/io/handle-cache.inline.h
R be/src/runtime/io/
R be/src/runtime/io/request-context.h
A be/src/runtime/io/request-ranges.h
R be/src/runtime/io/
M be/src/runtime/row-batch.h
M be/src/runtime/
M be/src/runtime/runtime-state.h
M be/src/runtime/test-env.h
M be/src/runtime/
M be/src/runtime/
M be/src/runtime/tmp-file-mgr.h
38 files changed, 1,417 insertions(+), 1,310 deletions(-)

  git pull ssh:// refs/changes/24/8424/9
To view, visit
To unsubscribe, visit

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If807f93a47d8027a43e56dd80b1b535d0bb74e1b
Gerrit-Change-Number: 8424
Gerrit-PatchSet: 9
Gerrit-Owner: Tim Armstrong <>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell <>
Gerrit-Reviewer: Tim Armstrong <>

  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message