impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-4591: Bound Kudu client error mem usage
Date Thu, 16 Nov 2017 23:47:32 GMT
Tim Armstrong has posted comments on this change. ( )

Change subject: IMPALA-4591: Bound Kudu client error mem usage

Patch Set 2: Code-Review+1

File be/src/exec/
PS1, Line 52: 
> No, its not documented, and of course it specifically says that it may be c
Yeah that's true, we did warn people. Should be fine to remove, was probably being too cautious.
Agree that the alternative is unnecessarily complicated.
PS1, Line 39: DEFINE_int32(kudu_mutation_buffer_size, DEFAULT_KUDU_MUTATION_BUFFER_SIZE,
> I think that's a reasonable idea, though like you say these probably don't 
File be/src/exec/
PS2, Line 193:   LOG(INFO) << "asdf error_buffer_size=" << error_buffer_size;
Stray debug log
File tests/custom_cluster/
PS1, Line 66:   @CustomClusterTestSuite.with_args(impalad_args="-kudu_error_buffer_size=1024")
> It takes a very large number of errors to hit the default limit (>10m "Key 
Thanks for explaining, this seems fine then.

To view, visit
To unsubscribe, visit

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I186ddb3f3b5865e08f17dba57cf6640591d06b14
Gerrit-Change-Number: 8464
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Tauber-Marshall <>
Gerrit-Reviewer: Thomas Tauber-Marshall <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-Comment-Date: Thu, 16 Nov 2017 23:47:32 +0000
Gerrit-HasComments: Yes

  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message