impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vuk Ercegovac (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4985: use parquet stats of nested types for dynamic pruning
Date Thu, 16 Nov 2017 22:19:48 GMT
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8480 )

Change subject: IMPALA-4985: use parquet stats of nested types for dynamic pruning
......................................................................


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/8480/3/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java:

http://gerrit.cloudera.org:8080/#/c/8480/3/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@179
PS3, Line 179: it is checked to be not empty.
> It could help to explain how that check is generated, e.g. by mentioning th
Done


http://gerrit.cloudera.org:8080/#/c/8480/3/testdata/workloads/functional-query/queries/QueryTest/nested-types-parquet-stats.test
File testdata/workloads/functional-query/queries/QueryTest/nested-types-parquet-stats.test:

http://gerrit.cloudera.org:8080/#/c/8480/3/testdata/workloads/functional-query/queries/QueryTest/nested-types-parquet-stats.test@98
PS3, Line 98: !empty
> Do we introduce the "!empty" guard somewhere and explain what it means?
added a reference to where its discussed.


http://gerrit.cloudera.org:8080/#/c/8480/3/testdata/workloads/functional-query/queries/QueryTest/nested-types-parquet-stats.test@145
PS3, Line 145: # Nested access in left-outer-join that would be incorrect if scan was pruned.
> Impressive find! Can you reword this to emphasize that this does not allow 
credit goes to Alex-- its a fun one. reworded.



-- 
To view, visit http://gerrit.cloudera.org:8080/8480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c99e20cb080b504442cd5376ea3e046016158fe
Gerrit-Change-Number: 8480
Gerrit-PatchSet: 3
Gerrit-Owner: Vuk Ercegovac <vercegovac@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <vercegovac@cloudera.com>
Gerrit-Comment-Date: Thu, 16 Nov 2017 22:19:48 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message