impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-6080: clean up table descriptor handling
Date Thu, 16 Nov 2017 21:43:28 GMT
Impala Public Jenkins has submitted this change and it was merged. (

Change subject: IMPALA-6080: clean up table descriptor handling

IMPALA-6080: clean up table descriptor handling

* Add DescriptorTbl::CreateHdfsTableDescriptor to avoid having to
   create an entire DescriptorTbl during INSERT finalization (when only
   a descriptor for the output table is needed)
* Remove TQueryExecRequest.desc_tbl, there's already a home for it in

This required fixing a problem in the planner test infrastructure
where the TQueryCtx was reused for planning multiple times despite
being modified during planning.

This is based on Marcel Kornacker's coordinator cleanup

Ran core tests.

Change-Id: Id427dab0c196b556bd8b2d64ec618403d5cbd4d6
Reviewed-by: Tim Armstrong <>
Tested-by: Impala Public Jenkins
M be/src/runtime/
M be/src/runtime/
M be/src/runtime/descriptors.h
M common/thrift/Frontend.thrift
M fe/src/main/java/org/apache/impala/service/
M fe/src/test/java/org/apache/impala/planner/
6 files changed, 116 insertions(+), 110 deletions(-)

  Tim Armstrong: Looks good to me, approved
  Impala Public Jenkins: Verified

To view, visit
To unsubscribe, visit

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id427dab0c196b556bd8b2d64ec618403d5cbd4d6
Gerrit-Change-Number: 8330
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tianyi Wang <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-Reviewer: anujphadke <>

  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message