impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-2248: Make idle session timeout a query option
Date Thu, 16 Nov 2017 19:22:02 GMT
Dan Hecht has posted comments on this change. ( )

Change subject: IMPALA-2248: Make idle_session_timeout a query option

Patch Set 6:

(1 comment)
File be/src/service/
PS6, Line 210:               &session_->set_query_options_mask));
> I call SetQueryOption in SessionState::SetTimeout, which is called by Updat
By unset I mean "set blah ''", i.e. setting the query option to the empty string.

There are other ways query options can be set besides the SET sql. e.g. confOverlay / configuration
in the HS2/beeswax execution RPCs, admission control pool configurations, etc. What should/does
happen in these cases?

The functional end-to-end test (aka pytests) test impala functionality regardless of how it's
exposed. I'm not saying JDBC/ODBC testing isn't good but lets also look at the idle session
timeout and query option tests to see what makes sense.

If SetTimeout has a side effect of changing query options, then that needs to be documented.
But i'm not sure that's the right code structure given the layering in which query options

To view, visit
To unsubscribe, visit

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I32e2775f80da387b0df4195fe2c5435b3f8e585e
Gerrit-Change-Number: 8490
Gerrit-PatchSet: 6
Gerrit-Owner: Zoltan Borok-Nagy <>
Gerrit-Reviewer: Attila Jeges <>
Gerrit-Reviewer: Csaba Ringhofer <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Gabor Kaszab <>
Gerrit-Reviewer: Laszlo Gaal <>
Gerrit-Reviewer: Michael Ho <>
Gerrit-Reviewer: Thomas Tauber-Marshall <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-Reviewer: Zoltan Borok-Nagy <>
Gerrit-Comment-Date: Thu, 16 Nov 2017 19:22:02 +0000
Gerrit-HasComments: Yes

  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message