impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-3436: Return a decimal when rounding a double
Date Thu, 16 Nov 2017 05:00:29 GMT
Alex Behm has posted comments on this change. ( )

Change subject: IMPALA-3436: Return a decimal when rounding a double

Patch Set 3:

(1 comment)
File common/function-registry/
PS3, Line 285:   [['round_v1','dround_v1'],
> It's totally plausible to me that someone would write a query with a non-co
I agree could be legit uses cases for non-const precisions.

Regarding mitigation: I hope we all agree that a round() returning a double makes no sense.
So even if we add a fround() alias we will need a strategy for eventually getting rid of it
at a later time. In the meantime, we'll need to preserve the code and tests to make sure fround()
does not break, even if we remove decimal_v1. So to me it feels like fround() is prolonging
the inevitable removal of round() returning a double.

To view, visit
To unsubscribe, visit

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I240ec70da7996bbfefcf6438eba4dff8d33d7bd6
Gerrit-Change-Number: 8398
Gerrit-PatchSet: 3
Gerrit-Owner: Taras Bobrovytsky <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Taras Bobrovytsky <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-Comment-Date: Thu, 16 Nov 2017 05:00:29 +0000
Gerrit-HasComments: Yes

  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message