impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bikramjeet Vig (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-6084: Avoid using of global namespace for llvm
Date Tue, 14 Nov 2017 23:45:21 GMT
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8489 )

Change subject: IMPALA-6084: Avoid using of global namespace for llvm
......................................................................


Patch Set 4: Code-Review+1

(12 comments)

Looks good to me, just some cleanup left to do

http://gerrit.cloudera.org:8080/#/c/8489/4/be/src/codegen/codegen-anyval.cc
File be/src/codegen/codegen-anyval.cc:

http://gerrit.cloudera.org:8080/#/c/8489/4/be/src/codegen/codegen-anyval.cc@156
PS4, Line 156: // DecimalVal,
you can fit this in the previous line


http://gerrit.cloudera.org:8080/#/c/8489/4/be/src/codegen/codegen-callgraph.cc
File be/src/codegen/codegen-callgraph.cc:

http://gerrit.cloudera.org:8080/#/c/8489/4/be/src/codegen/codegen-callgraph.cc@41
PS4, Line 41: for (llvm::Use& u : val->uses())
I think we usually stick to using no space between ":" like 
"for (llvm::Use& u: val->uses())" but I see exceptions in the codebase to this rule.
Can someone please confirm?


http://gerrit.cloudera.org:8080/#/c/8489/4/be/src/codegen/instruction-counter.cc
File be/src/codegen/instruction-counter.cc:

http://gerrit.cloudera.org:8080/#/c/8489/4/be/src/codegen/instruction-counter.cc@43
PS4, Line 43:   // Create all instruction counter and put them into counters_. Any
            :   // InstructionCount that has instructions delegated to it in
            :   // InstructionCounter::visit(const Instruction &I)
can fit in 2 lines


http://gerrit.cloudera.org:8080/#/c/8489/4/be/src/codegen/llvm-codegen.cc
File be/src/codegen/llvm-codegen.cc:

http://gerrit.cloudera.org:8080/#/c/8489/4/be/src/codegen/llvm-codegen.cc@1127
PS4, Line 1127: llvm::
search/replace gone wrong


http://gerrit.cloudera.org:8080/#/c/8489/4/be/src/exec/hash-table.cc
File be/src/exec/hash-table.cc:

http://gerrit.cloudera.org:8080/#/c/8489/4/be/src/exec/hash-table.cc@40
PS4, Line 40: using llvm::APFloat;
            : using llvm::ArrayRef;
            : using llvm::BasicBlock;
            : using llvm::ConstantFP;
            : using llvm::Function;
            : using llvm::LLVMContext;
            : using llvm::PHINode;
            : using llvm::PointerType;
            : using llvm::Type;
            : using llvm::Value;
you can remove these


http://gerrit.cloudera.org:8080/#/c/8489/4/be/src/exec/partitioned-hash-join-builder.cc
File be/src/exec/partitioned-hash-join-builder.cc:

http://gerrit.cloudera.org:8080/#/c/8489/4/be/src/exec/partitioned-hash-join-builder.cc@49
PS4, Line 49: using llvm::ConstantInt;
            : using llvm::Function;
            : using llvm::LLVMContext;
            : using llvm::PointerType;
            : using llvm::Type;
            : using llvm::Value
you can remove these


http://gerrit.cloudera.org:8080/#/c/8489/4/be/src/exec/partitioned-hash-join-node.cc
File be/src/exec/partitioned-hash-join-node.cc:

http://gerrit.cloudera.org:8080/#/c/8489/4/be/src/exec/partitioned-hash-join-node.cc@50
PS4, Line 50: using llvm::BasicBlock;
            : using llvm::ConstantInt;
            : using llvm::Function;
            : using llvm::GlobalValue;
            : using llvm::LLVMContext;
            : using llvm::PointerType;
            : using llvm::Type;
            : using llvm::Value;
you can remove these


http://gerrit.cloudera.org:8080/#/c/8489/4/be/src/exec/partitioned-hash-join-node.cc@131
PS4, Line 131: llvm::
search/replace gone wrong


http://gerrit.cloudera.org:8080/#/c/8489/4/be/src/exec/select-node.cc
File be/src/exec/select-node.cc:

http://gerrit.cloudera.org:8080/#/c/8489/4/be/src/exec/select-node.cc@30
PS4, Line 30: using llvm::Function;
you can remove this


http://gerrit.cloudera.org:8080/#/c/8489/4/be/src/exprs/scalar-expr.cc
File be/src/exprs/scalar-expr.cc:

http://gerrit.cloudera.org:8080/#/c/8489/4/be/src/exprs/scalar-expr.cc@260
PS4, Line 260: llvm::
search/replace gone wrong, after you fix that, you can fit this into one line


http://gerrit.cloudera.org:8080/#/c/8489/4/be/src/exprs/scalar-fn-call.cc
File be/src/exprs/scalar-fn-call.cc:

http://gerrit.cloudera.org:8080/#/c/8489/4/be/src/exprs/scalar-fn-call.cc@46
PS4, Line 46: using llvm::ArrayType;
            : using llvm::BasicBlock;
            : using llvm::Function;
            : using llvm::GlobalVariable;
            : using llvm::PointerType;
            : using llvm::Type;
            : using llvm::Value;
you can remove these


http://gerrit.cloudera.org:8080/#/c/8489/4/be/src/runtime/descriptors.cc
File be/src/runtime/descriptors.cc:

http://gerrit.cloudera.org:8080/#/c/8489/4/be/src/runtime/descriptors.cc@40
PS4, Line 40: using llvm::Constant;
            : using llvm::ConstantAggregateZero;
            : using llvm::ConstantInt;
            : using llvm::ConstantStruct;
            : using llvm::StructType;
you can remove these



-- 
To view, visit http://gerrit.cloudera.org:8080/8489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7098baff5f746bcc2965583ca99f6188997b733a
Gerrit-Change-Number: 8489
Gerrit-PatchSet: 4
Gerrit-Owner: Kim Jin Chul <jinchul@gmail.com>
Gerrit-Reviewer: Bikramjeet Vig <bikramjeet.vig@cloudera.com>
Gerrit-Reviewer: Kim Jin Chul <jinchul@gmail.com>
Gerrit-Reviewer: Philip Zeyliger <philip@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Nov 2017 23:45:21 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message