impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philip Zeyliger (Code Review)" <>
Subject [Impala-ASF-CR] [PREVIEW] IMPALA-4886: Expose table metrics in the catalog web UI.
Date Tue, 14 Nov 2017 20:00:54 GMT
Philip Zeyliger has posted comments on this change. (

Change subject: [PREVIEW] IMPALA-4886: Expose table metrics in the catalog web UI.

Patch Set 1:


I took a very brief look. I was worried when you said "lightweight framework", but it turns
out you're using codahale/yammer metrics, which is the right thing to do.

You know this, but TopNCache doesn't have a unit test.

I didn't look at all of this.
File common/thrift/JniCatalog.thrift:
PS1, Line 602:   1: required list<string> large_tables
Is the idea that len(large_tables)==len(memory_estimates), and likewise len(frequent_table)=len(num_metadata_operations)?
I think it'd be more honest for this to be "list<LargeTable> large_tables", with LargeTable
being a struct that has a tablename and details about that table that you want to share.
File fe/pom.xml:
PS1, Line 365:       <artifactId>metrics-core</artifactId>
Thanks. This is the right thing to use in my experience.
File fe/src/main/java/org/apache/impala/catalog/
PS1, Line 36:   // TODO: Consider making it a configurable parameter.
A somewhat cheap way to do this is to use:

Integer.getInteger("org.apache.impala.catalog.CatalogUsageMonitor.NUM_TABLES_TRACKED", 25)


That gets the number from system properties. It's pretty weak configuration, but I've used
it to nice effect for constants that really should be fine as is.

To view, visit
To unsubscribe, visit

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37d407979e6d3b1a444b6b6265900b148facde9e
Gerrit-Change-Number: 8529
Gerrit-PatchSet: 1
Gerrit-Owner: Dimitris Tsirogiannis <>
Gerrit-Reviewer: Dimitris Tsirogiannis <>
Gerrit-Reviewer: Philip Zeyliger <>
Gerrit-Comment-Date: Tue, 14 Nov 2017 20:00:54 +0000
Gerrit-HasComments: Yes

  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message