impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-6160: Allow multiple statements in a Query object.
Date Tue, 14 Nov 2017 14:55:26 GMT
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/8513 )

Change subject: IMPALA-6160: Allow multiple statements in a Query object.
......................................................................


Patch Set 4:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/8513/4/tests/performance/query_executor.py
File tests/performance/query_executor.py:

http://gerrit.cloudera.org:8080/#/c/8513/4/tests/performance/query_executor.py@45
PS4, Line 45: DDL/DML
nit: CRUD


http://gerrit.cloudera.org:8080/#/c/8513/4/tests/performance/query_executor.py@190
PS4, Line 190: query (Query)
nit: can you please pluralize query everywhere it can be multiple queries, including this
comment, line 200, the argument in line 206, the attribute on line 209, and so on?


http://gerrit.cloudera.org:8080/#/c/8513/4/tests/performance/query_executor.py@230
PS4, Line 230: (generally, DDL and DML statements)
nit: please remove



-- 
To view, visit http://gerrit.cloudera.org:8080/8513
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac86af181b7c42655f21d2c1efd4652dd35d9297
Gerrit-Change-Number: 8513
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Wood <twood@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Matthew Mulder <mmulder@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Tim Wood <twood@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Nov 2017 14:55:26 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message