impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5341: Avoid unintended filter out in fe test
Date Tue, 14 Nov 2017 14:32:07 GMT
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/8543 )

Change subject: IMPALA-5341: Avoid unintended filter out in fe test
......................................................................


Patch Set 1:

> (1 comment)
 > 
 > I would like to add a test which contains wrong row-size value and
 > the test should show that an error always happen. Unfortunately, I
 > haven't found any similar case from testdata. I thought JUnit test,
 > but E2E test should be required in this case.

In the walkthrough (https://lists.apache.org/thread.html/116ce61e65bfbb8ecbc7bd128609fd4e23d44385fe6357ed066b9818@%3Cdev.impala.apache.org%3E),
I wrote "Once that's done, try running the Planner tests on a test that includes row-size
again. This time, it should pass with the row-size as written and fail if you change the row-size,
like we did above."

Did you try that?


-- 
To view, visit http://gerrit.cloudera.org:8080/8543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie79f644a37b0ffab7b0d8e94e77650d56423697a
Gerrit-Change-Number: 8543
Gerrit-PatchSet: 1
Gerrit-Owner: Kim Jin Chul <jinchul@gmail.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Kim Jin Chul <jinchul@gmail.com>
Gerrit-Comment-Date: Tue, 14 Nov 2017 14:32:07 +0000
Gerrit-HasComments: No

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message