impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Russell (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] [DOCS] Remove unnecessary 'incubator' from URLs
Date Sat, 11 Nov 2017 21:05:15 GMT
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8524 )

Change subject: [DOCS] Remove unnecessary 'incubator' from URLs
......................................................................


Patch Set 1:

(1 comment)

Excellent idea!

http://gerrit.cloudera.org:8080/#/c/8524/1/docs/topics/impala_langref_unsupported.xml
File docs/topics/impala_langref_unsupported.xml:

http://gerrit.cloudera.org:8080/#/c/8524/1/docs/topics/impala_langref_unsupported.xml@207
PS1, Line 207: <xref href="http://sentry.apache.org/" scope="external" format="html">
Might as well shorten this opening tag to <xref keyref="sentry">. That way it picks
up the Sentry-related modification from impala_keydefs.ditamap, the line is shorter, and link
maintenance is easier in future (link can be changed again - to https:// or whatever - without
touching any topics/*.xml files).



-- 
To view, visit http://gerrit.cloudera.org:8080/8524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If0f8d51b147094e629e60c4a8c5aecbb6cdb6a8e
Gerrit-Change-Number: 8524
Gerrit-PatchSet: 1
Gerrit-Owner: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Laurel Hale <laurel@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Comment-Date: Sat, 11 Nov 2017 21:05:15 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message