impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Mulder (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE
Date Fri, 10 Nov 2017 03:04:58 GMT
Matthew Mulder has posted comments on this change. ( http://gerrit.cloudera.org:8080/8372 )

Change subject: IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE
......................................................................


Patch Set 5:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/8372/5/testdata/workloads/tpcds/queries/tpcds-q26.test
File testdata/workloads/tpcds/queries/tpcds-q26.test:

http://gerrit.cloudera.org:8080/#/c/8372/5/testdata/workloads/tpcds/queries/tpcds-q26.test@5
PS5, Line 5: 78.33333333333333
The TPC-DS spec section 7.5.3.d says "For results from AVG aggregates, the resulting values
must be within 1% of the query validation output data when reported to the nearest 1/100th,
rounded up." so I guess this is okay.


http://gerrit.cloudera.org:8080/#/c/8372/5/testdata/workloads/tpcds/queries/tpcds-q39-1.test
File testdata/workloads/tpcds/queries/tpcds-q39-1.test:

http://gerrit.cloudera.org:8080/#/c/8372/5/testdata/workloads/tpcds/queries/tpcds-q39-1.test@4
PS5, Line 4: -- ADD ROUND()s TO 4th, 5th, 9th, 10th COLUMNS, USE ACTUAL RESULT AS EXPECTED
RESULT.
It looks like this is okay per the TPC-DS standard section 4.2.3.4.f.6: Explicit Casting -
Scalar functions (such as CAST) whose sole purpose is to affect result precision for operations
involving integer columns or values may be applied. The resulting syntax must have equivalent
semantic behavior.



-- 
To view, visit http://gerrit.cloudera.org:8080/8372
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I79d2e34621639c8f8c4c4eb0b0944eaefca13a7a
Gerrit-Change-Number: 8372
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Wood <twood@cloudera.com>
Gerrit-Reviewer: Greg Rahn <grahn@cloudera.com>
Gerrit-Reviewer: Matthew Mulder <mmulder@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mmokhtar@cloudera.com>
Gerrit-Reviewer: Tim Wood <twood@cloudera.com>
Gerrit-Comment-Date: Fri, 10 Nov 2017 03:04:58 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message