impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tianyi Wang (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter
Date Thu, 09 Nov 2017 00:20:21 GMT
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8498 )

Change subject: IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/8498/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/8498/1//COMMIT_MSG@13
PS1, Line 13: finalization is performed in Coordinator::GetNext after we hit eos.
> nit: Add "after we hit 'eos'"
Done


http://gerrit.cloudera.org:8080/#/c/8498/1//COMMIT_MSG@13
PS1, Line 13: fter we hit eos.
            : A bug in Base64Decode related to quer
> Could you briefly mention what the noticeable implications were of this bug
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/8498
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04bb76d20541fa035d88167b593d1b8bc3873e89
Gerrit-Change-Number: 8498
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang <twang@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <twang@cloudera.com>
Gerrit-Comment-Date: Thu, 09 Nov 2017 00:20:21 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message