impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tianyi Wang (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt
Date Thu, 09 Nov 2017 00:06:02 GMT
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8414 )

Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt
......................................................................


Patch Set 7:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/8414/4/be/src/runtime/disk-io-mgr.cc
File be/src/runtime/disk-io-mgr.cc:

http://gerrit.cloudera.org:8080/#/c/8414/4/be/src/runtime/disk-io-mgr.cc@797
PS4, Line 797: 
> So I understand the rule now. Once the DiskIoRequestContext is cancelled, t
So is the fix here still correct? Here only a range is cancelled and the client should still
function.


http://gerrit.cloudera.org:8080/#/c/8414/7/be/src/runtime/exec-env.cc
File be/src/runtime/exec-env.cc:

http://gerrit.cloudera.org:8080/#/c/8414/7/be/src/runtime/exec-env.cc@38
PS7, Line 38: #include "runtime/io/disk-io-mgr.h"
include order


http://gerrit.cloudera.org:8080/#/c/8414/7/be/src/runtime/io/disk-io-mgr-stress.cc
File be/src/runtime/io/disk-io-mgr-stress.cc:

http://gerrit.cloudera.org:8080/#/c/8414/7/be/src/runtime/io/disk-io-mgr-stress.cc@204
PS7, Line 204:     if (clients_[i].reader != nullptr) {
Is it possible? ClientThread set reader to NULL in L165.


http://gerrit.cloudera.org:8080/#/c/8414/7/be/src/runtime/io/disk-io-mgr-test.cc
File be/src/runtime/io/disk-io-mgr-test.cc:

http://gerrit.cloudera.org:8080/#/c/8414/7/be/src/runtime/io/disk-io-mgr-test.cc@25
PS7, Line 25: #include "runtime/io/request-context.h"
include order



-- 
To view, visit http://gerrit.cloudera.org:8080/8414
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If5cb42437d11c13bc4a55c3ab426b66777332bd1
Gerrit-Change-Number: 8414
Gerrit-PatchSet: 7
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <twang@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Comment-Date: Thu, 09 Nov 2017 00:06:02 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message