impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-4252: Min-max runtime filters for Kudu
Date Thu, 09 Nov 2017 00:02:39 GMT
Alex Behm has posted comments on this change. ( )

Change subject: IMPALA-4252: Min-max runtime filters for Kudu

Patch Set 13:


Looks pretty good to me
File be/src/exec/
PS13, Line 200:             if (!filter->GetCastIntMinMax(col_type, &int_min, &int_max))
Unfortunate that that every Kudu client has to do this.

We should consider filing a JIRA against Kudu to address perform this logic on their side.
File be/src/util/
PS13, Line 139:       return std::numeric_limits<int64_t>::max();
using std::numeric_limits; at the top if this file
PS13, Line 165: #define NUMERIC_MIN_MAX_FILTER_CAST(NAME)                           \
Brief comment especially about the return value would be good.
File fe/src/main/java/org/apache/impala/planner/
PS13, Line 604:         // must be a SlotRef pointing to a column. Wc can allow implicit integer
typo: We can allow implicit integer casts
PS13, Line 605:         // by casting the min/max value before sending them to Kudu.
min/max values
File testdata/workloads/functional-query/queries/QueryTest/min_max_filters.test:
PS13, Line 98: where a.tinyint_col = b.int_col
Let's make the min/max filter selective, e.g. by adding where b.int_col in (0,1) or something
like that
PS13, Line 103: # The min/max values in the filter are outside the range representable for
the target col.
Let's also add a non-selective case where the min/max values fall outside the range of the
target column, something like:

select STRAIGHT_JOIN count(*)
from alltypes a join [BROADCAST]
  (values(min_int() x), (max_int())) v
where a.tinyint_col = v.x

To view, visit
To unsubscribe, visit

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02bad890f5b5f78388a3041bf38f89369b5e2f1c
Gerrit-Change-Number: 7793
Gerrit-PatchSet: 13
Gerrit-Owner: Thomas Tauber-Marshall <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Anonymous Coward #345
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Lars Volker <>
Gerrit-Reviewer: Matthew Jacobs <>
Gerrit-Reviewer: Michael Ho <>
Gerrit-Reviewer: Mostafa Mokhtar <>
Gerrit-Reviewer: Thomas Tauber-Marshall <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-Reviewer: Todd Lipcon <>
Gerrit-Comment-Date: Thu, 09 Nov 2017 00:02:39 +0000
Gerrit-HasComments: Yes

  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message