impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Knupp (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-6148: Specifying thirdparty deps as URLs
Date Wed, 08 Nov 2017 20:54:49 GMT
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/8456 )

Change subject: IMPALA-6148: Specifying thirdparty deps as URLs
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/8456/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/8456/4//COMMIT_MSG@10
PS4, Line 10: ,
Nit: this comma is probably not necessary; it actually kind of makes the sentence less clear.


http://gerrit.cloudera.org:8080/#/c/8456/2/bin/bootstrap_toolchain.py
File bin/bootstrap_toolchain.py:

http://gerrit.cloudera.org:8080/#/c/8456/2/bin/bootstrap_toolchain.py@112
PS2, Line 112:     if re.search(k, release):
> You can't trivially cache v because it depends on the argument 'release'. 
This is probably an obtuse question (you can count on me for those): for any given invocation
of this script, won't release always be the same thing? E.g., if I'm bootstrapping the toolchain
on my dev machine, the release will only ever resolve to ubuntu14.04, no matter how many times
"lsb_release -irs" gets called (57 times, it turns out -- fewer if parts of the toolchain
are already there.)



-- 
To view, visit http://gerrit.cloudera.org:8080/8456
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4628d86022d4bd8b762313f7056d76416a58b422
Gerrit-Change-Number: 8456
Gerrit-PatchSet: 4
Gerrit-Owner: Philip Zeyliger <philip@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <philip@cloudera.com>
Gerrit-Reviewer: Zach Amsden <zamsden@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Nov 2017 20:54:49 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message