impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zoltan Borok-Nagy (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-2248: Make idle session timeout a query option
Date Wed, 08 Nov 2017 11:49:11 GMT
Zoltan Borok-Nagy has posted comments on this change. (

Change subject: IMPALA-2248: Make idle_session_timeout a query option

Patch Set 4:

File be/src/service/
PS3, Line 204: if (iequals(key, "idle_session_timeout")) {
> Its unfortunate this is special cased here. Could you add a comment explain
PS3, Line 205:           // IMPALA-2248: For some client, we need to enable to set
> Could you extract the body of the 'if' to a new function in order to keep t
PS3, Line 213: 
             :       } else {
> single line
File be/src/service/
PS3, Line 189: DEFINE_int32(idle_session_timeout, 0, "The time, in seconds, that a session
may be idle"
> Note how this interacts with the query option.
File common/thrift/ImpalaService.thrift:
PS3, Line 292:   // The time, in seconds, that a session may be idle for before it is closed
(and all
> Note how this interacts with the flag.
File fe/src/test/java/org/apache/impala/service/
PS3, Line 594: 
> "0, 5, 10"'s and "timeout * 1.5"'s relation could be more explicit, for exa
Partly done.
I don't feel that the asList part is necessary, but I introduced a timeoutTolerance variable.
File fe/src/test/java/org/apache/impala/util/
PS3, Line 26: /**
> Could you please write a short comment to describe the purpose of this clas

To view, visit
To unsubscribe, visit

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I32e2775f80da387b0df4195fe2c5435b3f8e585e
Gerrit-Change-Number: 8490
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <>
Gerrit-Reviewer: Attila Jeges <>
Gerrit-Reviewer: Csaba Ringhofer <>
Gerrit-Reviewer: Gabor Kaszab <>
Gerrit-Reviewer: Laszlo Gaal <>
Gerrit-Reviewer: Michael Ho <>
Gerrit-Reviewer: Thomas Tauber-Marshall <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-Reviewer: Zoltan Borok-Nagy <>
Gerrit-Comment-Date: Wed, 08 Nov 2017 11:49:11 +0000
Gerrit-HasComments: Yes

  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message