impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-6155: Allow tests to pass when ORDER BY does not cover the query.
Date Wed, 08 Nov 2017 00:13:56 GMT
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8484
)

Change subject: IMPALA-6155: Allow tests to pass when ORDER BY does not cover the query.
......................................................................

IMPALA-6155: Allow tests to pass when ORDER BY does not cover the query.

Use VERIFY_IS_EQUAL_SORTED tag on RESULTS section to allow low-order
sort deviations to compare.

Testing:
- Passed local tests/run-tests.py ...
- Changed order of expected rows by low-order column and verified test still passes.
- Analyzed all TPC-DS query files for similar patterns, found no others.

Change-Id: Ib42ba64ce6ac9b75b4a532f20cee0055aaed5a6c
Reviewed-on: http://gerrit.cloudera.org:8080/8484
Reviewed-by: Michael Brown <mikeb@cloudera.com>
Reviewed-by: Tim Armstrong <tarmstrong@cloudera.com>
Tested-by: Impala Public Jenkins
---
M testdata/workloads/tpcds/queries/tpcds-q77a.test
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Michael Brown: Looks good to me, but someone else must approve
  Tim Armstrong: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/8484
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib42ba64ce6ac9b75b4a532f20cee0055aaed5a6c
Gerrit-Change-Number: 8484
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Wood <twood@cloudera.com>
Gerrit-Reviewer: Greg Rahn <grahn@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Tim Wood <twood@cloudera.com>

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message