impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Wood (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-6155: Allow tests to pass when ORDER BY does not cover the query.
Date Tue, 07 Nov 2017 20:41:36 GMT
Hello Greg Rahn, Michael Brown, Tim Armstrong, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/8484

to look at the new patch set (#3).

Change subject: IMPALA-6155: Allow tests to pass when ORDER BY does not cover the query.
......................................................................

IMPALA-6155: Allow tests to pass when ORDER BY does not cover the query.

Use VERIFY_IS_EQUAL_SORTED tag on RESULTS section to allow low-order
sort deviations to compare.

Testing:
- Passed local tests/run-tests.py ...
- Changed order of expected rows by low-order column and verified test still passes.
- Analyzed all TPC-DS query files for similar patterns, found no others.

Change-Id: Ib42ba64ce6ac9b75b4a532f20cee0055aaed5a6c
---
M testdata/workloads/tpcds/queries/tpcds-q77a.test
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/84/8484/3
-- 
To view, visit http://gerrit.cloudera.org:8080/8484
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib42ba64ce6ac9b75b4a532f20cee0055aaed5a6c
Gerrit-Change-Number: 8484
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Wood <twood@cloudera.com>
Gerrit-Reviewer: Greg Rahn <grahn@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Tim Wood <twood@cloudera.com>

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message