impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-6151: add query-level fragment/backend counters
Date Tue, 07 Nov 2017 18:24:09 GMT
Tim Armstrong has posted comments on this change. ( )

Change subject: IMPALA-6151: add query-level fragment/backend counters

Patch Set 5:

(1 comment)
File be/src/service/
PS5, Line 953:   ImpaladMetrics::NUM_QUERIES_REGISTERED->Increment(1L);
> On the /queries webpage, I think "num_in_flight_queries" is this same numbe
Oh, I see, I didn't look at the queries json. The queries page seems internally inconsistent
- num_in_flight_queries includes "queries in flight" and "queries waiting to be closed". But
yeah, I deliberately avoided using the term "in flight" because it's unclear whether it should
include queries that are waiting to be closed.

I don't like inventing a new term but this does seem less ambiguous going forward.

It would be nice to re-evaluate all the names but probably best to do that all at once instead
of piecemeal, since it will require considering impact on other tools, like you mentioned.

To view, visit
To unsubscribe, visit

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3df350414733e98d1ec28adc1c98f45bb0c4e3e9
Gerrit-Change-Number: 8461
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Armstrong <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Mostafa Mokhtar <>
Gerrit-Reviewer: Thomas Tauber-Marshall <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-Comment-Date: Tue, 07 Nov 2017 18:24:09 +0000
Gerrit-HasComments: Yes

  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message