impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Tauber-Marshall (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-2248: Make idle session timeout a query option
Date Tue, 07 Nov 2017 17:03:55 GMT
Thomas Tauber-Marshall has posted comments on this change. (

Change subject: IMPALA-2248: Make idle_session_timeout a query option

Patch Set 3:

File be/src/service/
PS3, Line 204: if (iequals(key, "idle_session_timeout")) {
Its unfortunate this is special cased here. Could you add a comment explaining why that's
PS3, Line 213: key, value,
             :               &session_->set_query_options,
single line
File be/src/service/
PS3, Line 189: DEFINE_int32(idle_session_timeout, 0, "The time, in seconds, that a session
may be idle"
Note how this interacts with the query option.
File common/thrift/ImpalaService.thrift:
PS3, Line 292:   // The time, in seconds, that a session may be idle for before it is closed
(and all
Note how this interacts with the flag.

To view, visit
To unsubscribe, visit

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I32e2775f80da387b0df4195fe2c5435b3f8e585e
Gerrit-Change-Number: 8490
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <>
Gerrit-Reviewer: Attila Jeges <>
Gerrit-Reviewer: Csaba Ringhofer <>
Gerrit-Reviewer: Gabor Kaszab <>
Gerrit-Reviewer: Laszlo Gaal <>
Gerrit-Reviewer: Michael Ho <>
Gerrit-Reviewer: Thomas Tauber-Marshall <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-Comment-Date: Tue, 07 Nov 2017 17:03:55 +0000
Gerrit-HasComments: Yes

  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message