impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joe McDonnell (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-6148: Specifying thirdparty deps as URLs
Date Tue, 07 Nov 2017 01:34:01 GMT
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8456 )

Change subject: IMPALA-6148: Specifying thirdparty deps as URLs
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8456/3/bin/impala-config.sh
File bin/impala-config.sh:

http://gerrit.cloudera.org:8080/#/c/8456/3/bin/impala-config.sh@138
PS3, Line 138: # Download URLs for toolchain dependencies can be overridden by
             : # IMPALA_<PACKAGE>_URLs in impala-config-*.sh. We unset them here first:
             : for var in "${!IMPALA_@}"; do
             :   if [[ "$var" == IMPALA_*_URL ]]; then
             :     unset $var
             :   fi
             : done
If I understand this correctly, setting these in the environment won't work. Instead, they
must be set in impala-config-branch.sh or impala-config-local.sh. Is that what we want?

One thing that we do for some environment variables crucial to the build is to have an OVERRIDE
version of these variables. Sometimes we also respect the environment itself. See:
DOWNLOAD_CDH_COMPONENTS
HADOOP_INCLUDE_DIR_OVERRIDE
HADOOP_LIB_DIR_OVERRIDE
HIVE_SRC_DIR_OVERRIDE



-- 
To view, visit http://gerrit.cloudera.org:8080/8456
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4628d86022d4bd8b762313f7056d76416a58b422
Gerrit-Change-Number: 8456
Gerrit-PatchSet: 3
Gerrit-Owner: Philip Zeyliger <philip@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <philip@cloudera.com>
Gerrit-Reviewer: Zach Amsden <zamsden@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Nov 2017 01:34:01 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message