impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-6155: Ensure TPC-DS result orders can't vary.
Date Tue, 07 Nov 2017 01:20:53 GMT
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8484 )

Change subject: IMPALA-6155: Ensure TPC-DS result orders can't vary.
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8484/2/testdata/workloads/tpcds/queries/tpcds-q77a.test
File testdata/workloads/tpcds/queries/tpcds-q77a.test:

http://gerrit.cloudera.org:8080/#/c/8484/2/testdata/workloads/tpcds/queries/tpcds-q77a.test@120
PS2, Line 120: ---- RESULTS
Another option is to use the VERIFY_IS_EQUAL_SORTED verifier instead of modifying the query.
That's not very strict but might be better than diverging the queries further from the official
TPC-DS versions. I haven't been following that closely so not sure what the general approach
has been with modifications vs changing the verification logic.



-- 
To view, visit http://gerrit.cloudera.org:8080/8484
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib42ba64ce6ac9b75b4a532f20cee0055aaed5a6c
Gerrit-Change-Number: 8484
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wood <twood@cloudera.com>
Gerrit-Reviewer: Greg Rahn <grahn@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Tim Wood <twood@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Nov 2017 01:20:53 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message