impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-3613: Avoid topic updates to unregistered subscriber instances
Date Mon, 06 Nov 2017 22:05:12 GMT
Alex Behm has posted comments on this change. ( )

Change subject: IMPALA-3613: Avoid topic updates to unregistered subscriber instances

Patch Set 3:

(1 comment)
File be/src/statestore/
PS3, Line 278:   lock_guard<SpinLock> l(subscribers_lock_);
             :   lock_guard<mutex> t(topic_lock_);
> IMO, we shouldn't use spinlock for topic_lock_ since we can potentially do 
My general opinion on this is "if it ain't broke, don't fix it". Do we have any evidence that
these locks are a problem, or is this a case of premature optimization?

In any case, this is not the main focus of this patch, so let's avoid creeping in unrelated
changes. I vote for reverting.

If we have evidence that a mutex is not good here, then let's change that in a separate patch.

To view, visit
To unsubscribe, visit

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0329ae7d23dc6e9b04b7bc3ee8d89cbc73756f65
Gerrit-Change-Number: 8449
Gerrit-PatchSet: 3
Gerrit-Owner: Bharath Vissapragada <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Bharath Vissapragada <>
Gerrit-Reviewer: Dimitris Tsirogiannis <>
Gerrit-Reviewer: Sailesh Mukil <>
Gerrit-Comment-Date: Mon, 06 Nov 2017 22:05:12 +0000
Gerrit-HasComments: Yes

  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message