impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5307: Part 4: copy out uncompressed text and seq
Date Mon, 06 Nov 2017 21:29:31 GMT
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8172 )

Change subject: IMPALA-5307: Part 4: copy out uncompressed text and seq
......................................................................


Patch Set 11:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/8172/11/be/src/exec/hdfs-scanner.cc
File be/src/exec/hdfs-scanner.cc:

http://gerrit.cloudera.org:8080/#/c/8172/11/be/src/exec/hdfs-scanner.cc@234
PS11, Line 234: false
Should the callers pass an argument 'copy_strings' ? On the other hand, this may diverge from
the codegen'd path. May be a TODO for now ?


http://gerrit.cloudera.org:8080/#/c/8172/11/be/src/exec/hdfs-scanner.cc@313
PS11, Line 313: TextConverter::CodegenWriteSlot
One thing I noticed is that the TextConverter::WriteSlot() already has logic to copy the char/varchar/string
to the argument 'pool' although the caller below at line 233 always passes 'copy_string' as
false. Not sure if you considered refactoring it or it's not worth it ?

Ideally, if we can propagate replace 'slot_desc' with a constant argument, we may be able
to re-use the logic in TextConverter::WriteSlot() and avoids the need for hand-crafted IR
in TextConverter::CodegenWriteSlot(). This doesn't have to be part of this change as this
patch is more about memory transfer.

May be a TODO ?



-- 
To view, visit http://gerrit.cloudera.org:8080/8172
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I304fd002b61bfedf41c8b1405cd7eb7b492bb941
Gerrit-Change-Number: 8172
Gerrit-PatchSet: 11
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Nov 2017 21:29:31 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message