impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt
Date Mon, 06 Nov 2017 17:31:19 GMT
Hello Tianyi Wang, 

I'd like you to reexamine a change. Please visit

to look at the new patch set (#5).

Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt

IMPALA-4835: Part 1: simplify I/O mgr mem mgmt

In preparation for switching the I/O mgr to the buffer pool, this
removes and cleans up a lot of code so that the switchover patch starts
from a cleaner slate.

* Remove the free buffer cache (which will be replaced by buffer pool's
  own caching).
* Make memory limit exceeded error checking synchronous (in anticipation
  of having to propagate buffer pool errors synchronously).
* Misc other refactoring and simplification.

This will probably regress performance somewhat because of the cache
removal, so my plan is to merge it around the same time as switching
the I/O mgr to allocate from the buffer pool. I'm keeping the patches
separate to make reviewing easier.

* Ran exhaustive tests
* Ran the disk-io-mgr-stress-test overnight

Change-Id: If5cb42437d11c13bc4a55c3ab426b66777332bd1
M be/src/exec/
M be/src/exec/
M be/src/runtime/
M be/src/runtime/io/
M be/src/runtime/io/
M be/src/runtime/io/
M be/src/runtime/io/disk-io-mgr.h
M be/src/runtime/io/
M be/src/runtime/io/request-context.h
M be/src/runtime/io/request-ranges.h
M be/src/runtime/io/
M be/src/runtime/mem-tracker.h
M be/src/runtime/
M be/src/runtime/
M be/src/util/
M be/src/util/impalad-metrics.h
16 files changed, 252 insertions(+), 599 deletions(-)

  git pull ssh:// refs/changes/14/8414/5
To view, visit
To unsubscribe, visit

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If5cb42437d11c13bc4a55c3ab426b66777332bd1
Gerrit-Change-Number: 8414
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Armstrong <>
Gerrit-Reviewer: Tianyi Wang <>

  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message