impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-4252: Min-max runtime filters for Kudu
Date Fri, 03 Nov 2017 23:22:11 GMT
Alex Behm has posted comments on this change. ( )

Change subject: IMPALA-4252: Min-max runtime filters for Kudu

Patch Set 11:

Commit Message:
PS9, Line 27: 
> RUNTIME_FILTER_WAIT_TIME_MS applies the same to bloom and min-max - its the
Thanks for explaining.
Can you add this text into a Google Doc for us to keep track of the evolution/meaning of these
query options? No need to polish, just put it somewhere.

I think the new types of filters will affect our query options in non-trivial ways and we
should come up with a plan that minimizes user confusion, adding new options, and deprecating
PS9, Line 41: 
> Those results are posted in the review comments. I can include them here as
Thanks. No need to add here.
File common/thrift/ImpalaInternalService.thrift:
PS9, Line 202:   // Maximum number of bloom runtime filters allowed per query
> There's basically two reasons for this:
Thanks. Please add this text to a Google Doc for tracking the evolution of these query options.

Even though the min/max filters are smaller and bounded in size, I think extreme queries with
a large number of joins and join conditions can still cause havoc. Keep in mind that we now
allow an *unbounded* number of such filters. Crazy queries will happen.

We should not hold this patch, but the lack of safeguards is concerning to me and we should
continue thinking.
File common/thrift/PlanNodes.thrift:
PS9, Line 103:   12: optional string kudu_col_name
case sensitive?
File fe/src/main/java/org/apache/impala/planner/
PS11, Line 359:     public Operator getJoinOp() { return exprCmpOp_; }
PS11, Line 602:         if (!(targetExpr instanceof SlotRef)
I think only explicit casts are problematic. Implicit casts should be ok, or am I missing
File testdata/workloads/functional-query/queries/QueryTest/runtime_filters.test:
PS11, Line 144:     on a.month = cast(b.month + 10000 as int);
Was this your change? Why the change?

To view, visit
To unsubscribe, visit

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02bad890f5b5f78388a3041bf38f89369b5e2f1c
Gerrit-Change-Number: 7793
Gerrit-PatchSet: 11
Gerrit-Owner: Thomas Tauber-Marshall <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Anonymous Coward #345
Gerrit-Reviewer: Lars Volker <>
Gerrit-Reviewer: Matthew Jacobs <>
Gerrit-Reviewer: Michael Ho <>
Gerrit-Reviewer: Mostafa Mokhtar <>
Gerrit-Reviewer: Thomas Tauber-Marshall <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-Reviewer: Todd Lipcon <>
Gerrit-Comment-Date: Fri, 03 Nov 2017 23:22:11 +0000
Gerrit-HasComments: Yes

  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message