impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Wood (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE
Date Fri, 03 Nov 2017 00:16:24 GMT
Tim Wood has posted comments on this change. ( http://gerrit.cloudera.org:8080/8372 )

Change subject: IMPALA-6087: Revisit tests withheld from TPC-DS suite for use of TRUNCATE
......................................................................


Patch Set 4:

> Patch Set 4:
> 
> > Patch Set 4:
> > 
> > What about Mostafa's question:
> > > How many iterations did you try for those tests?
> 
> I thought I answered it:
> > For example, q47 failed in 4 different test runs on 9/18 because of an LSD difference.
 ...[I]t's passing now that I replaced the old expected output with the new....
> 
> Am I not understanding "iterations" in this context?

Taking a guess at the question, here are the numbers of attempts of each of these tests in
my local workspace since I started on this test suite:
-------- q26
59
-------- q28
29
-------- q47
39
-------- q57
31
-------- q59
28
-------- q63
28


-- 
To view, visit http://gerrit.cloudera.org:8080/8372
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I79d2e34621639c8f8c4c4eb0b0944eaefca13a7a
Gerrit-Change-Number: 8372
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Wood <twood@cloudera.com>
Gerrit-Reviewer: Greg Rahn <grahn@cloudera.com>
Gerrit-Reviewer: Matthew Mulder <mmulder@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mmokhtar@cloudera.com>
Gerrit-Reviewer: Tim Wood <twood@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Nov 2017 00:16:24 +0000
Gerrit-HasComments: No

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message