impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Csaba Ringhofer (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options
Date Thu, 02 Nov 2017 20:13:10 GMT
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8038
)

Change subject: IMPALA-5736: Add impala-shell argument to set default query options
......................................................................


Patch Set 18:

> Csaba, it's hard to see, but the build failed the Apache RAT check.
 > If you search 'FAILED JOB' at https://jenkins.impala.io/job/gerrit-verify-dryrun/1425/console
 > you see a pointer to https://jenkins.impala.io/job/rat-check-ub1604/111/
 > . In there is:
 > 
 > 22:05:14 + bin/check-rat-report.py bin/rat_exclude_files.txt
 > rat.xml
 > 22:05:15 UNAPPROVED: tests/shell/impalarc_with_error
 > 22:05:15 UNAPPROVED: tests/shell/impalarc_with_query_options
 > 22:05:15 UNAPPROVED: tests/shell/impalarc_with_warnings
 > 
 > I think these exclusions can be added to bin/rat_exclude_files.txt
 > in this section, alongside the existing shell test data exclusions:
 > 
 > # http://www.apache.org/legal/src-headers.html: "Test data for
 > which the addition of a
 > # source header would cause the tests to fail."

Thanks for the hint! I have added a test impalarc files to  bin/rat_exclude_files.txt.


-- 
To view, visit http://gerrit.cloudera.org:8080/8038
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26a3b67230c80a99bd246b6af205d558fec9a986
Gerrit-Change-Number: 8038
Gerrit-PatchSet: 18
Gerrit-Owner: Csaba Ringhofer <csringhofer@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <csringhofer@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mjacobs@apache.org>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <philip@cloudera.com>
Gerrit-Reviewer: anujphadke <aphadke@cloudera.com>
Gerrit-Comment-Date: Thu, 02 Nov 2017 20:13:10 +0000
Gerrit-HasComments: No

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message