impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zoram Thanga (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-5599: Clean up references to TimestampValue in be/src.
Date Wed, 01 Nov 2017 20:21:22 GMT
Zoram Thanga has posted comments on this change. ( )

Change subject: IMPALA-5599: Clean up references to TimestampValue in be/src.

Patch Set 11:

File be/src/service/client-request-state.h:
PS11, Line 342: start_time_us_, end_time_us_;
> These two may need to be initialized.
File be/src/service/
PS11, Line 303: record.end_time_us - record.start_time_us;
> This may be broken if end_time_us is not set yet. The old code will use the
Fixing via
File be/src/service/impala-server.h:
PS11, Line 622:     /// Start and end time of the query, in Unix microseconds.
              :     int64_t start_time_us, end_time_us;
> Can these be const ? They are always initialized in the constructor, right 
The default constructor does not handle this well if we make them constants. We'll have to
make all/most of the other fields constant as well if we are going to fix this.

To view, visit
To unsubscribe, visit

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I642a1d713597826bb7c15cd2ecb6638cb813a02c
Gerrit-Change-Number: 8305
Gerrit-PatchSet: 11
Gerrit-Owner: Zoram Thanga <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Ho <>
Gerrit-Reviewer: Zoram Thanga <>
Gerrit-Comment-Date: Wed, 01 Nov 2017 20:21:22 +0000
Gerrit-HasComments: Yes

  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message