Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id EBD7F200D2E for ; Tue, 31 Oct 2017 19:24:50 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id EA9331609EF; Tue, 31 Oct 2017 18:24:50 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 39A9A1609E6 for ; Tue, 31 Oct 2017 19:24:50 +0100 (CET) Received: (qmail 87757 invoked by uid 500); 31 Oct 2017 18:24:49 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 87746 invoked by uid 99); 31 Oct 2017 18:24:49 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 31 Oct 2017 18:24:49 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 6F325D29C7 for ; Tue, 31 Oct 2017 18:24:48 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id N9Zbgwgbn6qb for ; Tue, 31 Oct 2017 18:24:47 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id D293B5F1D5 for ; Tue, 31 Oct 2017 18:24:46 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v9VIOiII022938; Tue, 31 Oct 2017 18:24:44 GMT Message-Id: <201710311824.v9VIOiII022938@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 3 Date: Tue, 31 Oct 2017 18:24:44 +0000 From: "Tim Armstrong (Code Review)" To: Taras Bobrovytsky , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Michael Ho , anujphadke , Zach Amsden , Dan Hecht X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4964=3A_Fix_Decimal_modulo_overflow=0A?= X-Gerrit-Change-Id: I5420201d4440d421e33e443df005cdcc16b8a6cd X-Gerrit-Change-Number: 8329 X-Gerrit-ChangeURL: X-Gerrit-Commit: f91c3948137913968b828e0326091e2d39c50335 In-Reply-To: References: X-Gerrit-Comment-Date: Tue, 31 Oct 2017 18:24:44 +0000 Reply-To: tarmstrong@cloudera.com, zamsden@cloudera.com, impala-cr@cloudera.com, aphadke@cloudera.com, marcelk@gmail.com, kwho@cloudera.com, dhecht@cloudera.com, tbobrovytsky@cloudera.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="dMbPmEt1s2Q="; charset=UTF-8 archived-at: Tue, 31 Oct 2017 18:24:51 -0000 --dMbPmEt1s2Q= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Tim Armstrong has posted comments on this change=2E ( http://gerrit=2Ecloud= era=2Eorg:8080/8329 ) Change subject: IMPALA-4964: Fix Decimal modulo over= flow =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E Patch = Set 3: I'll do another pass with fresh eyes=2E I didn't have any specific = concerns=2E -- To view, visit http://gerrit=2Ecloudera=2Eorg:8080/8329 T= o unsubscribe, visit http://gerrit=2Ecloudera=2Eorg:8080/settings Gerrit-P= roject: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit= -Change-Id: I5420201d4440d421e33e443df005cdcc16b8a6cd Gerrit-Change-Number:= 8329 Gerrit-PatchSet: 3 Gerrit-Owner: Taras Bobrovytsky Gerrit-Reviewer: Dan Hecht Gerrit-Revie= wer: Michael Ho Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zach Amsden Gerrit-Re= viewer: anujphadke Gerrit-Comment-Date: Tue, 31 Oc= t 2017 18:24:44 +0000 Gerrit-HasComments: No --dMbPmEt1s2Q=--