Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id DFF8A200D2E for ; Tue, 31 Oct 2017 18:00:38 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id DE8C91609EF; Tue, 31 Oct 2017 17:00:38 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3031C1609E6 for ; Tue, 31 Oct 2017 18:00:38 +0100 (CET) Received: (qmail 97435 invoked by uid 500); 31 Oct 2017 17:00:37 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 97423 invoked by uid 99); 31 Oct 2017 17:00:37 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 31 Oct 2017 17:00:37 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 651711A38E3 for ; Tue, 31 Oct 2017 17:00:36 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id IcpIgW_oKjum for ; Tue, 31 Oct 2017 17:00:35 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 577595F666 for ; Tue, 31 Oct 2017 17:00:34 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v9VH0VEF019208; Tue, 31 Oct 2017 17:00:31 GMT Message-Id: <201710311700.v9VH0VEF019208@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 3 Date: Tue, 31 Oct 2017 17:00:31 +0000 From: "Sailesh Mukil (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Alex Behm , Lars Volker , Tim Armstrong X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-6126=3A_ASAN_detects_heap-use-after-free_in_thrift-server-test=0A?= X-Gerrit-Change-Id: I2cd434757de2cd384def5b360a479e51812cccca X-Gerrit-Change-Number: 8412 X-Gerrit-ChangeURL: X-Gerrit-Commit: ad857c412c14021fd03b1a7623de1502b617ca10 In-Reply-To: References: X-Gerrit-Comment-Date: Tue, 31 Oct 2017 17:00:31 +0000 Reply-To: sailesh@cloudera.com, impala-cr@cloudera.com, lv@cloudera.com, marcelk@gmail.com, tarmstrong@cloudera.com, alex.behm@cloudera.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="4K3HVzaV/OI="; charset=UTF-8 archived-at: Tue, 31 Oct 2017 17:00:39 -0000 --4K3HVzaV/OI= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sailesh Mukil has posted comments on this change=2E ( http://gerrit=2Ecloud= era=2Eorg:8080/8412 ) Change subject: IMPALA-6126: ASAN detects heap-use-a= fter-free in thrift-server-test =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E Patch Set 3: Looks like I found the real bug=2E The S= ASL library takes the string and holds a reference to it instead of copying= it in sasl_server_init()=2E However, when we reinitialize the SASL librar= y, it doesn't take in the new string because it detects that it was already= previously initialized: https://github=2Ecom/cyrusimap/cyrus-sasl/blob/mas= ter/lib/server=2Ec#L841 And we end up discarding the string that was held = by it=2E So the fix is to get the string once and make sure it lives as lo= ng as the process does=2E -- To view, visit http://gerrit=2Ecloudera=2Eo= rg:8080/8412 To unsubscribe, visit http://gerrit=2Ecloudera=2Eorg:8080/sett= ings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: = comment Gerrit-Change-Id: I2cd434757de2cd384def5b360a479e51812cccca Gerrit-= Change-Number: 8412 Gerrit-PatchSet: 3 Gerrit-Owner: Sailesh Mukil Gerrit-Reviewer: Alex Behm Ge= rrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Sailesh Mukil Gerrit-R= eviewer: Tim Armstrong Gerrit-Comment-Date: Tue= , 31 Oct 2017 17:00:31 +0000 Gerrit-HasComments: No --4K3HVzaV/OI=--