Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 96F9F200D53 for ; Tue, 31 Oct 2017 05:00:43 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 95ADD160BE4; Tue, 31 Oct 2017 04:00:43 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E38BF160BF8 for ; Tue, 31 Oct 2017 05:00:42 +0100 (CET) Received: (qmail 65831 invoked by uid 500); 31 Oct 2017 04:00:42 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 65809 invoked by uid 99); 31 Oct 2017 04:00:41 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 31 Oct 2017 04:00:41 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id D43F8CF160 for ; Tue, 31 Oct 2017 04:00:40 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id K2UXwj5oWsiq for ; Tue, 31 Oct 2017 04:00:39 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id EF2115FE0E for ; Tue, 31 Oct 2017 04:00:38 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v9V40bID010698; Tue, 31 Oct 2017 04:00:38 GMT Message-Id: <201710310400.v9V40bID010698@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 8 Date: Tue, 31 Oct 2017 04:00:37 +0000 From: "Impala Public Jenkins (Code Review)" To: Lars Volker , impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: merged Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-6124=3A_Fix_alter_table_ddl_updates_and_test=0A?= X-Gerrit-Change-Id: I3126252e7709304d3e1fa4bb06a0b847180bd6cf X-Gerrit-Change-Number: 8411 X-Gerrit-ChangeURL: X-Gerrit-Commit: 471285bee3b8d4e18f97153fa0bd95641bba0d78 In-Reply-To: References: Reply-To: impala-cr@cloudera.com, lv@cloudera.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="ZbRFCG9jSbY="; charset=UTF-8 archived-at: Tue, 31 Oct 2017 04:00:43 -0000 --ZbRFCG9jSbY= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Impala Public Jenkins has submitted this change and it was merged=2E ( http= ://gerrit=2Ecloudera=2Eorg:8080/8411 ) Change subject: IMPALA-6124: Fix al= ter table ddl updates and test =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E IMPALA-6124: Fix alter table ddl updates and test Impa= la would previously update the ddl time of a table when dropping a partitio= n but not when adding one=2E This change removes updates to the ddl time wh= en partitions are added or removed to be consistent with Hive=2E Additiona= lly the check in the ddl update test would fail if some operations took lon= ger than 20 seconds=2E Instead, this change makes sure that the ddl time in= creases as intended=2E To test this change I ran test_last_ddl_time_update= in exhaustive mode and also ran a private S3 build=2E Change-Id: I3126252= e7709304d3e1fa4bb06a0b847180bd6cf Reviewed-on: http://gerrit=2Ecloudera=2Eo= rg:8080/8411 Reviewed-by: Bharath Vissapragada Te= sted-by: Impala Public Jenkins --- M fe/src/main/java/org/apache/impala/ser= vice/CatalogOpExecutor=2Ejava M tests/metadata/test_last_ddl_time_update=2E= py 2 files changed, 6 insertions(+), 9 deletions(-) Approvals: Bharath V= issapragada: Looks good to me, approved Impala Public Jenkins: Verified = -- To view, visit http://gerrit=2Ecloudera=2Eorg:8080/8411 To unsubscribe,= visit http://gerrit=2Ecloudera=2Eorg:8080/settings Gerrit-Project: Impala= -ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I31= 26252e7709304d3e1fa4bb06a0b847180bd6cf Gerrit-Change-Number: 8411 Gerrit-Pa= tchSet: 8 Gerrit-Owner: Lars Volker Gerrit-Reviewer: Al= ex Behm Gerrit-Reviewer: Bharath Vissapragada = Gerrit-Reviewer: Impala Public Jenkins Gerrit-Rev= iewer: Lars Volker --ZbRFCG9jSbY=--