Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 09B38200D3C for ; Tue, 31 Oct 2017 00:43:20 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 08600160BF8; Mon, 30 Oct 2017 23:43:20 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4DE86160BE4 for ; Tue, 31 Oct 2017 00:43:19 +0100 (CET) Received: (qmail 53677 invoked by uid 500); 30 Oct 2017 23:43:18 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 53665 invoked by uid 99); 30 Oct 2017 23:43:18 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Oct 2017 23:43:18 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 685241A2DDD for ; Mon, 30 Oct 2017 23:43:17 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id HkYKo87VKU4m for ; Mon, 30 Oct 2017 23:43:16 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id EDB4F60D1C for ; Mon, 30 Oct 2017 23:43:15 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v9UNhC9b004343; Mon, 30 Oct 2017 23:43:13 GMT Message-Id: <201710302343.v9UNhC9b004343@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 4 Date: Mon, 30 Oct 2017 23:43:12 +0000 From: "Alex Behm (Code Review)" To: Lars Volker , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Bharath Vissapragada X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-6124=3A_Fix_alter_table_ddl_updates_and_test=0A?= X-Gerrit-Change-Id: I3126252e7709304d3e1fa4bb06a0b847180bd6cf X-Gerrit-Change-Number: 8411 X-Gerrit-ChangeURL: X-Gerrit-Commit: 63616049d6380f7befed2a089f4771abd228765c In-Reply-To: References: X-Gerrit-Comment-Date: Mon, 30 Oct 2017 23:43:12 +0000 Reply-To: alex.behm@cloudera.com, impala-cr@cloudera.com, lv@cloudera.com, marcelk@gmail.com, bharathv@cloudera.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="s7qBG2OCOhw="; charset=UTF-8 archived-at: Mon, 30 Oct 2017 23:43:20 -0000 --s7qBG2OCOhw= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Alex Behm has posted comments on this change=2E ( http://gerrit=2Ecloudera= =2Eorg:8080/8411 ) Change subject: IMPALA-6124: Fix alter table ddl update= s and test =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E = Patch Set 4: (1 comment) http://gerrit=2Ecloudera=2Eorg:8080/#/c/8411/4/t= ests/metadata/test_last_ddl_time_update=2Epy File tests/metadata/test_last_= ddl_time_update=2Epy: http://gerrit=2Ecloudera=2Eorg:8080/#/c/8411/4/tests= /metadata/test_last_ddl_time_update=2Epy@25 PS4, Line 25: class TestLastDdl= TimeUpdate(ImpalaTestSuite): > Does this test still make sense? There's no = code on our side that modifies Sorry, I was thinking ahead=2E Nvm this com= ment=2E -- To view, visit http://gerrit=2Ecloudera=2Eorg:8080/8411 To u= nsubscribe, visit http://gerrit=2Ecloudera=2Eorg:8080/settings Gerrit-Proj= ect: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Ch= ange-Id: I3126252e7709304d3e1fa4bb06a0b847180bd6cf Gerrit-Change-Number: 84= 11 Gerrit-PatchSet: 4 Gerrit-Owner: Lars Volker Gerrit-= Reviewer: Alex Behm Gerrit-Reviewer: Bharath V= issapragada Gerrit-Reviewer: Lars Volker Gerrit-Comment-Date: Mon, 30 Oct 2017 23:43:12 +0000 Gerrit-Has= Comments: Yes --s7qBG2OCOhw=--