Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201710302044.v9UKiEko026685@ip-10-146-233-104.ec2.internal>
Date: Mon, 30 Oct 2017 20:44:13 +0000
From: "Michael Ho (Code Review)" <gerrit@cloudera.org>
To: Tim Armstrong <tarmstrong@cloudera.com>, impala-cr@cloudera.com,
        reviews@impala.incubator.apache.org
CC: Thomas Tauber-Marshall <tmarshall@cloudera.com>,
        Dan Hecht <dhecht@cloudera.com>
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5307=3A_Part_2=3A_copy_out_strings_in_uncompressed_Avro=0A?=
In-Reply-To: <gerrit.1506468960000.If1fc78790d778c874f5aafa5958c3c045a88d233@gerrit.cloudera.org>
References: <gerrit.1506468960000.If1fc78790d778c874f5aafa5958c3c045a88d233@gerrit.cloudera.org>
Reply-To: kwho@cloudera.com, impala-cr@cloudera.com, marcelk@gmail.com,
        tarmstrong@cloudera.com, dhecht@cloudera.com, tmarshall@cloudera.com,
        reviews@impala.incubator.apache.org
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.14.2
Content-Type: multipart/alternative; boundary="BGcyjNPgEDI="; charset=UTF-8
archived-at: Mon, 30 Oct 2017 20:44:19 -0000

--BGcyjNPgEDI=
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Michael Ho has posted comments on this change=2E ( http://gerrit=2Ecloudera=
=2Eorg:8080/8146 )

Change subject: IMPALA-5307: Part 2: copy out strings i=
n uncompressed Avro
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E


Patch Set 15:

(3 comments)

http://gerrit=2Ecloudera=2Eorg:8080/#=
/c/8146/15/be/src/exec/hdfs-avro-scanner-ir=2Ecc
File be/src/exec/hdfs-avro=
-scanner-ir=2Ecc:

http://gerrit=2Ecloudera=2Eorg:8080/#/c/8146/15/be/src/e=
xec/hdfs-avro-scanner-ir=2Ecc@51
PS15, Line 51: !tuple->CopyStrings("HdfsAv=
roScanner::DecodeAvroData()",
             :               state_, string_s=
lot_offsets_=2Edata(), string_slot_offsets_=2Esize(), pool,
             : =
              &parse_status_))
nit: tuple->CopyStrings(=2E=2E=2E) =3D=3D nu=
llptr


http://gerrit=2Ecloudera=2Eorg:8080/#/c/8146/15/be/src/exec/hdfs-av=
ro-scanner=2Ecc
File be/src/exec/hdfs-avro-scanner=2Ecc:

http://gerrit=2Ec=
loudera=2Eorg:8080/#/c/8146/15/be/src/exec/hdfs-avro-scanner=2Ecc@1066
PS15=
, Line 1066: HdfsScanNodeBase* node
Should this be const HdfsScanNodeBase* =
?


http://gerrit=2Ecloudera=2Eorg:8080/#/c/8146/15/be/src/runtime/tuple-ir=
=2Ecc
File be/src/runtime/tuple-ir=2Ecc:

http://gerrit=2Ecloudera=2Eorg:80=
80/#/c/8146/15/be/src/runtime/tuple-ir=2Ecc@28
PS15, Line 28: for (int i =
=3D 0; i < num_string_slots; ++i) {
Not sure if it will help but have you t=
ried #pragma unroll hint here to see if it makes a difference=2E

https://c=
lang=2Ellvm=2Eorg/docs/AttributeReference=2Ehtml#pragma-unroll-pragma-nounr=
oll


-- 
To view, visit http://gerrit=2Ecloudera=2Eorg:8080/8146
To unsub=
scribe, visit http://gerrit=2Ecloudera=2Eorg:8080/settings

Gerrit-Project:=
 Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change=
-Id: If1fc78790d778c874f5aafa5958c3c045a88d233
Gerrit-Change-Number: 8146
G=
errit-PatchSet: 15
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera=2Ecom>
=
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera=2Ecom>
Gerrit-Reviewer: Michael=
 Ho <kwho@cloudera=2Ecom>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshal=
l@cloudera=2Ecom>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera=2Ecom=
>
Gerrit-Comment-Date: Mon, 30 Oct 2017 20:44:13 +0000
Gerrit-HasComments: =
Yes

--BGcyjNPgEDI=--