Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 8EC86200D27 for ; Wed, 25 Oct 2017 23:23:53 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 8D256160BDA; Wed, 25 Oct 2017 21:23:53 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D175C1609CE for ; Wed, 25 Oct 2017 23:23:52 +0200 (CEST) Received: (qmail 1063 invoked by uid 500); 25 Oct 2017 21:23:52 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 1045 invoked by uid 99); 25 Oct 2017 21:23:51 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Oct 2017 21:23:51 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 07A08180863 for ; Wed, 25 Oct 2017 21:23:51 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id xf8hLf0rAG6R for ; Wed, 25 Oct 2017 21:23:49 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id EC3E05FD14 for ; Wed, 25 Oct 2017 21:23:48 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v9PLNm5w014655; Wed, 25 Oct 2017 21:23:48 GMT Message-Id: <201710252123.v9PLNm5w014655@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 2 Date: Wed, 25 Oct 2017 21:23:47 +0000 From: "Tianyi Wang (Code Review)" To: Thomas Tauber-Marshall , Tim Armstrong , Dan Hecht , impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-2758=3A_Remove_BufferedTupleStream=3A=3AGetRows=0A?= X-Gerrit-Change-Id: I3831c38994da2b69775a9809ff01de5d23584414 X-Gerrit-Change-Number: 8226 X-Gerrit-ChangeURL: X-Gerrit-Commit: 1eb207347c1bf5b306b0533d452663baa15f21d5 In-Reply-To: References: Reply-To: twang@cloudera.com, impala-cr@cloudera.com, marcelk@gmail.com, tarmstrong@cloudera.com, dhecht@cloudera.com, tmarshall@cloudera.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="T1tSi0GIa7M="; charset=UTF-8 archived-at: Wed, 25 Oct 2017 21:23:53 -0000 --T1tSi0GIa7M= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hello Thomas Tauber-Marshall, Tim Armstrong, Dan Hecht, I'd like you to r= eexamine a change=2E Please visit http://gerrit=2Ecloudera=2Eorg:8080/= 8226 to look at the new patch set (#2)=2E Change subject: IMPALA-2758: Re= move BufferedTupleStream::GetRows =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E IMPALA-2758: Remove BufferedTupleStream::GetRows Th= is patch removes BufferedTupleStream::GetRows=2E This function pins a strea= m and reads all the rows into a single batch=2E It is not a good API since = it creates an arbitrarily large row batch=2E In this patch the call sites p= in the stream and then directly use GetNext to retrieve a single batch at a= time=2E Testing: It passes existing tests=2E A test case for GetRows is r= emoved=2E Change-Id: I3831c38994da2b69775a9809ff01de5d23584414 --- M be/sr= c/exec/partitioned-hash-join-node=2Ecc M be/src/exec/partitioned-hash-join-= node=2Eh M be/src/runtime/buffered-tuple-stream-test=2Ecc M be/src/runtime/= buffered-tuple-stream=2Ecc M be/src/runtime/buffered-tuple-stream=2Eh 5 fil= es changed, 57 insertions(+), 90 deletions(-) git pull ssh://gerrit=2Ec= loudera=2Eorg:29418/Impala-ASF refs/changes/26/8226/2 -- To view, visit ht= tp://gerrit=2Ecloudera=2Eorg:8080/8226 To unsubscribe, visit http://gerrit= =2Ecloudera=2Eorg:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: = master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3831c38994da2b697= 75a9809ff01de5d23584414 Gerrit-Change-Number: 8226 Gerrit-PatchSet: 2 Gerri= t-Owner: Tianyi Wang Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tianyi Wang Gerrit-Revi= ewer: Tim Armstrong --T1tSi0GIa7M=--