Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 347DF200D33 for ; Wed, 25 Oct 2017 00:19:27 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 330181609C8; Tue, 24 Oct 2017 22:19:27 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 78EA6160BF1 for ; Wed, 25 Oct 2017 00:19:26 +0200 (CEST) Received: (qmail 55594 invoked by uid 500); 24 Oct 2017 22:19:25 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 55541 invoked by uid 99); 24 Oct 2017 22:19:25 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Oct 2017 22:19:25 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id AB862180718 for ; Tue, 24 Oct 2017 22:19:24 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.363 X-Spam-Level: ** X-Spam-Status: No, score=2.363 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id ylsnn9Y3Zr7T for ; Tue, 24 Oct 2017 22:19:23 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 767FC5FDCE for ; Tue, 24 Oct 2017 22:19:23 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v9OMJMnc025291; Tue, 24 Oct 2017 22:19:22 GMT Message-Id: <201710242219.v9OMJMnc025291@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 3 Date: Tue, 24 Oct 2017 22:19:22 +0000 From: "Impala Public Jenkins (Code Review)" To: Tianyi Wang , impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: merged Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-6099=3A_Fix_crash_in_CheckForAlwaysFalse=28=29=0A?= X-Gerrit-Change-Id: I3eda43845b78516c1e76e07e0d2dd9d862168e1d X-Gerrit-Change-Number: 8369 X-Gerrit-ChangeURL: X-Gerrit-Commit: 2bd010781c07fee9dc09924856ac7ced11e6be3e In-Reply-To: References: Reply-To: impala-cr@cloudera.com, twang@cloudera.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="ciePonY6oOQ="; charset=UTF-8 archived-at: Tue, 24 Oct 2017 22:19:27 -0000 --ciePonY6oOQ= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Impala Public Jenkins has submitted this change and it was merged=2E ( http= ://gerrit=2Ecloudera=2Eorg:8080/8369 ) Change subject: IMPALA-6099: Fix cr= ash in CheckForAlwaysFalse() =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E IMPALA-6099: Fix crash in CheckForAlwaysFalse() Filter st= ates indexed by FilterStats::ROW_GROUPS_KEY was only relevant if the runtim= e filter is bound by partitioning columns=2E This is no longer true since a= lways-false filter can filter out row groups as well, which results in a cr= ash in CheckForAlwaysFalse()=2E This patch registers row groups counters un= conditionally to fix this bug=2E Change-Id: I3eda43845b78516c1e76e07e0d2dd= 9d862168e1d Reviewed-on: http://gerrit=2Ecloudera=2Eorg:8080/8369 Reviewed-= by: Tim Armstrong Tested-by: Impala Public Jenk= ins --- M be/src/exec/filter-context=2Ecc M be/src/exec/filter-context=2Eh = M be/src/exec/scan-node=2Ecc 3 files changed, 4 insertions(+), 6 deletions(= -) Approvals: Tim Armstrong: Looks good to me, approved Impala Public = Jenkins: Verified -- To view, visit http://gerrit=2Ecloudera=2Eorg:8080/8= 369 To unsubscribe, visit http://gerrit=2Ecloudera=2Eorg:8080/settings Ger= rit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Ge= rrit-Change-Id: I3eda43845b78516c1e76e07e0d2dd9d862168e1d Gerrit-Change-Num= ber: 8369 Gerrit-PatchSet: 3 Gerrit-Owner: Tianyi Wang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Ma= rshall Gerrit-Reviewer: Tim Armstrong --ciePonY6oOQ=--