Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 72468200D24 for ; Tue, 24 Oct 2017 22:45:58 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 70B87160BDB; Tue, 24 Oct 2017 20:45:58 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B55A11609C8 for ; Tue, 24 Oct 2017 22:45:57 +0200 (CEST) Received: (qmail 66434 invoked by uid 500); 24 Oct 2017 20:45:57 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 66423 invoked by uid 99); 24 Oct 2017 20:45:56 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Oct 2017 20:45:56 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id A7FA9180635 for ; Tue, 24 Oct 2017 20:45:55 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.363 X-Spam-Level: ** X-Spam-Status: No, score=2.363 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id jBeZe0ECWidj for ; Tue, 24 Oct 2017 20:45:54 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 67E485F239 for ; Tue, 24 Oct 2017 20:45:54 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v9OKjr8D021311; Tue, 24 Oct 2017 20:45:53 GMT Message-Id: <201710242045.v9OKjr8D021311@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 9 Date: Tue, 24 Oct 2017 20:45:53 +0000 From: "Bikramjeet Vig (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Tim Armstrong , Michael Ho X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4236=3A_Codegen_CopyRows=28=29_for_select_nodes=0A?= X-Gerrit-Change-Id: Ie0d496d004418468e16b6f564f90f45ebbf87c1e X-Gerrit-Change-Number: 8196 X-Gerrit-ChangeURL: X-Gerrit-Commit: c480cff7d032b4021d5305c8ce1ec804ba0e08b9 In-Reply-To: References: X-Gerrit-Comment-Date: Tue, 24 Oct 2017 20:45:53 +0000 Reply-To: bikramjeet.vig@cloudera.com, impala-cr@cloudera.com, marcelk@gmail.com, tarmstrong@cloudera.com, kwho@cloudera.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="WB8rMyVJ6r8="; charset=UTF-8 archived-at: Tue, 24 Oct 2017 20:45:58 -0000 --WB8rMyVJ6r8= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Bikramjeet Vig has posted comments on this change=2E ( http://gerrit=2Eclou= dera=2Eorg:8080/8196 ) Change subject: IMPALA-4236: Codegen CopyRows() for= select nodes =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= Patch Set 9: (2 comments) http://gerrit=2Ecloudera=2Eorg:8080/#/c/8196= /8/be/src/exec/select-node=2Ecc File be/src/exec/select-node=2Ecc: http://= gerrit=2Ecloudera=2Eorg:8080/#/c/8196/8/be/src/exec/select-node=2Ecc@72 PS8= , Line 72: Status( > It's probably quite clear what the call path is since = this is the codegen f both the message in the Status obj created and the in= formation logged by VerifyFunction() provide context related to the failed = finalize call=2E http://gerrit=2Ecloudera=2Eorg:8080/#/c/8196/9/tests/que= ry_test/test_codegen=2Epy File tests/query_test/test_codegen=2Epy: http://= gerrit=2Ecloudera=2Eorg:8080/#/c/8196/9/tests/query_test/test_codegen=2Epy@= 52 PS9, Line 52: assert_codegen_enabled(result=2Eruntime_profile, [1]) = > Optionally, you can consider adding a test in which codegen fails=2E Not = stri Do we already have tests that check for codegen failed? Also is there = a way I can induce a failure in codegen? -- To view, visit http://gerri= t=2Ecloudera=2Eorg:8080/8196 To unsubscribe, visit http://gerrit=2Ecloudera= =2Eorg:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerr= it-MessageType: comment Gerrit-Change-Id: Ie0d496d004418468e16b6f564f90f45e= bbf87c1e Gerrit-Change-Number: 8196 Gerrit-PatchSet: 9 Gerrit-Owner: Bikram= jeet Vig Gerrit-Reviewer: Bikramjeet Vig = Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-= Comment-Date: Tue, 24 Oct 2017 20:45:53 +0000 Gerrit-HasComments: Yes --WB8rMyVJ6r8=--